Rollback: (chore/373 자동 등록 도구 비활성화)으로 롤백#390
Merged
HeeMang-Lee merged 3 commits intodevfrom Aug 12, 2025
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Walkthrough이 PR은 cs25-service의 Dockerfile을 정리(노드 패키지 설치 방식 변경, 이미지 정리, 라벨/워크디렉터리 조정)하고, BraveSearchMcpService의 클라이언트 선택/초기화 흐름을 단순화했으며, application.properties에서 MCP 관련 타임아웃·명령 경로·초기화/오토컨피그 설정을 조정했습니다. Changes
Sequence Diagram(s)sequenceDiagram
actor Caller
participant Service as BraveSearchMcpService
participant C1 as McpSyncClient[1]
participant C2 as McpSyncClient[2]
participant CN as McpSyncClient[n]
Caller->>Service: search(query)
loop 순차 클라이언트 검사
Service->>C1: listTools()
alt C1에 brave_web_search 없음
Service->>C2: listTools()
alt C2에도 없음
Service->>CN: listTools()
end
end
end
alt 사용 가능한 클라이언트 발견
Service->>+SelectedClient: callTool(brave_web_search, params)
SelectedClient-->>-Service: JSON content (nullable)
Service-->>Caller: JSON 또는 빈 객체({})
else 미발견
Service-->>Caller: IllegalStateException(brave_web_search 미발견)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
wannabeing
approved these changes
Aug 12, 2025
wannabeing
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10차 - 11, 12 배포가 실패해서
10차 - 10으로 롤백합니다.
#374 까지로 롤백
Summary by CodeRabbit
Bug Fixes
Refactor
Chores